[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev added a comment. In D123031#3429801 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/55690/step_9.txt > > please take a look, etc :) Should be fixed in https://github.com/llvm/llvm-project/commit/211df7319af

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/55690/step_9.txt please take a look, etc :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 ___

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3de4d5e6dd66: [clangd] Use stable keys for CanonicalIncludes mappings (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420500. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Fix the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Just nits Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:359 if (Entry) { - auto PublicHeader = CanonIncludes.mapHeader(Entry->getName()); +

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420462. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.h:38 public: - /// Adds a string-to-string mapping from \p Path to \p CanonicalPath. - void addMapping(llvm::StringRef Path, llvm::StringRef CanonicalPath); + /// Adds a string-to-st

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420426. kbobyrev added a comment. Rebase correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tool

[PATCH] D123031: [clangd] Use stable keys for CanonicalIncludes mappings

kbobyrev updated this revision to Diff 420425. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123031/new/ https://reviews.llvm.org/D123031 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang