[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I've landed on your behalf in 882915df61e33f3a2b7f58e52f572717e1c11499 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost marked an inline comment as done. red1bluelost added a comment. If that's all good, could you commit on my behalf. Here is name and email: Micah Weston (micahswes...@gmail.com) Thanks for the great reviews! It was really helpful with learning the frontend stuff. Repository: rG

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost updated this revision to Diff 427627. red1bluelost marked 2 inline comments as done. red1bluelost added a comment. Addresses the last couple comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123009/new/ https://reviews.llvm.org/D

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor corrections. Btw, do you need someone to land this on your behalf? If so, what name and email address would you like used for patch attribution? ===

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost added inline comments. Comment at: clang/docs/ReleaseNotes.rst:113-114 by unary operators. +- ``-Wenum-conversion`` now warns on conversion of signed enum to unsigned enum + and unsigned enum to signed enum rather than ``-Wsign-conversion``. aa

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost updated this revision to Diff 426804. red1bluelost marked 4 inline comments as done. red1bluelost added a comment. Addresses comments to improve wording and remove unnecessary code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123009/n

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:113-114 by unary operators. +- ``-Wenum-conversion`` now warns on conversion of signed enum to unsigned enum + and unsigned enum to signed enum rather than ``-Wsign-conversion``. M

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost updated this revision to Diff 426786. red1bluelost added a comment. Adds regression tests for enum to int sign conversion warnings and notes the changes in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123009/new/ ht

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

aaron.ballman added a comment. Also, before we land this, you should add a release note to clang/docs/ReleaseNotes.rst about the bugfix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123009/new/ https://reviews.llvm.org/D123009 __

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

aaron.ballman added a comment. Thanks for the updates! I think this is getting somewhat close, but I'd like to see some additional test cases to ensure we're not regressing behavior we care about (I think we may be losing warnings about sign conversion). // Signed enums enum SE1 { N1 = -1 }

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost marked 3 inline comments as done. red1bluelost added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13555-13557 +DiagnoseImpCast(S, E, T, CC, DiagID); +if (!isa(Target) || !isa(Source)) + return; aaron.ballman wrote: > I do

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost updated this revision to Diff 424053. red1bluelost added a comment. Updates patch based on comments. Silences the sign conversions on enum-to-enum so that only enum-to-enum will warn. Simplifies the test case since now only one warning occurs. Repository: rG LLVM Github Monorepo

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for working on this, and for your patience -- this review fell off my radar for a bit, sorry about that! I think there's an issue here to be solved, but I'm n

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost created this revision. red1bluelost added reviewers: rsmith, lebedev.ri, aaron.ballman. Herald added a project: All. red1bluelost requested review of this revision. Herald added a project: clang. Ensures an -Wenum-conversion warning happens when one of the enums is signed and the othe