Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

2015-08-24 Thread Jonathan Roelofs via cfe-commits
jroelofs closed this revision. jroelofs added a comment. r245876 http://reviews.llvm.org/D12294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

2015-08-24 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Actually commit this as is and I'll handle the other cleanup. http://reviews.llvm.org/D12294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

2015-08-24 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after renaming `tested_elsewhere.pass.cpp` http://reviews.llvm.org/D12294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

2015-08-24 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Can you move the `libcpp-has-no-threads` tests to `test/libcxx/atomics` instead of deleting them? (I imagine that's what you intended to do). Also `tested_elsewhere.pass.cpp` shouldn't really be called that because it contains the actual test. Could you rename it to some

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

2015-08-24 Thread Jonathan Roelofs via cfe-commits
jroelofs updated this revision to Diff 32996. jroelofs added a comment. The diff uploaded strangely... trying again. http://reviews.llvm.org/D12294 Files: CMakeLists.txt test/libcxx/atomics/libcpp-has-no-threads.fail.cpp test/libcxx/atomics/libcpp-has-no-threads.pass.cpp test/std/atomic

[PATCH] D12294: Misc cleanups re-commandeered from D11963.

2015-08-24 Thread Jonathan Roelofs via cfe-commits
jroelofs created this revision. jroelofs added a reviewer: EricWF. jroelofs added a subscriber: cfe-commits. This separates out the bits of D11963 which were drive-by fixes, which aren't really relevant to the __config_site part of that change. http://reviews.llvm.org/D12294 Files: CMakeLists