[PATCH] D122871: Clang-Formatting

ps-19 abandoned this revision. ps-19 added a comment. Closed as: 1. Formating test file causes build to fail. 2. Formatting of whole page is not accpeted in LLVM as it created problem future with commands like `git blame` . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D122871: Clang-Formatting

ps-19 added a comment. Pardon, it was my mistake i didn't see that the file i was amending was actually a test file i just search "switch" statement in my script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122871/new/ https://reviews.llvm.org/D

[PATCH] D122871: Clang-Formatting

junaire added a comment. You are not supposed to format the test, because the comment is actually something we called regression tests. If you reformat it (put it in the wrong place), the test will fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D122871: Clang-Formatting

aaron.ballman added a comment. In D122871#3422061 , @ps-19 wrote: > okay now i understand the issue completely. > If i just mentioned that i am formatting a test file it would be correct then > according to my patch. We don't typically reformat whole fi

[PATCH] D122871: Clang-Formatting

ps-19 added a comment. okay now i understand the issue completely. If i just mentioned that i am formatting a test file it would be correct then according to my patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122871/new/ https://reviews.llvm.

[PATCH] D122871: Clang-Formatting

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. I'm confused -- the issue you linked is for a bug with clang-format but the changes in your patch don't modify clang-format, just modifies a test file to be formatted.

[PATCH] D122871: Clang-Formatting

ps-19 added a comment. I think inbuilt clang formatter in llvm ate up my work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122871/new/ https://reviews.llvm.org/D122871 ___ cfe-commits mailing list cfe-

[PATCH] D122871: Clang-Formatting

ps-19 created this revision. ps-19 added reviewers: aaron.ballman, ktkachov, xbolva00, jyknight, jy7.yang, jyasskin, jyh, jyimusuuhilik, Dan, DaAnIV, danalbert, Danbab, danbeam. Herald added a project: All. ps-19 requested review of this revision. Herald added a project: clang-tools-extra. Herald