Re: [PATCH] D12287: Add replace-auto_ptr check.

2015-08-25 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 33066. angelgarcia added a comment. Use the full message once in the test, and truncate all the other patterns. http://reviews.llvm.org/D12287 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/moder

Re: [PATCH] D12287: Add replace-auto_ptr check.

2015-08-25 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Thank you! Comment at: test/clang-tidy/modernize-replace-auto-ptr.cpp:12 @@ +11,3 @@ +std::auto_ptr create_derived_ptr(); +// CHECK-MESSAGES: :[[@LIN

Re: [PATCH] D12287: Add replace-auto_ptr check.

2015-08-25 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 33055. angelgarcia added a comment. Add check description. http://reviews.llvm.org/D12287 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/ReplaceAutoPtrCheck.cpp clang-tidy/modernize/R

Re: [PATCH] D12287: Add replace-auto_ptr check.

2015-08-24 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/modernize/ReplaceAutoPtrCheck.h:20 @@ +19,3 @@ + +class ReplaceAutoPtrCheck : public ClangTidyCheck { +public: Please add a class comment describing what the check does and why. http://reviews.llvm.org/D12287

[PATCH] D12287: Add replace-auto_ptr check.

2015-08-24 Thread Angel Garcia via cfe-commits
angelgarcia created this revision. angelgarcia added a reviewer: alexfh. angelgarcia added subscribers: cfe-commits, klimek. Migrate replace-auto_ptr check from clang-modernize to modernize module in clang-tidy. http://reviews.llvm.org/D12287 Files: clang-tidy/modernize/CMakeLists.txt clang