This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd33c36235df1: [lit] Fix setup of sanitizer environment
(authored by vitalybuka).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ychen accepted this revision.
ychen added a comment.
This revision is now accepted and ready to land.
I'm looking at relevant code recently. This LGTM.
Comment at: clang/test/Unit/lit.cfg.py:33
-# Propagate path to symbolizer for ASan/MSan.
-for symbolizer in ['ASAN_SYMBOLIZE
vitalybuka added inline comments.
Comment at: clang/test/Unit/lit.cfg.py:33
-# Propagate path to symbolizer for ASan/MSan.
-for symbolizer in ['ASAN_SYMBOLIZER_PATH', 'MSAN_SYMBOLIZER_PATH']:
-if symbolizer in os.environ:
-config.environment[symbolizer] = os.environ
ychen added inline comments.
Comment at: clang/test/Unit/lit.cfg.py:33
-# Propagate path to symbolizer for ASan/MSan.
-for symbolizer in ['ASAN_SYMBOLIZER_PATH', 'MSAN_SYMBOLIZER_PATH']:
-if symbolizer in os.environ:
-config.environment[symbolizer] = os.environ[symb
vitalybuka updated this revision to Diff 419816.
vitalybuka added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122869/new/
https://reviews.llvm.org/D122869
Files:
clang/test/Unit/lit.cfg.py
clang/test/lit.cfg.py
cross-proj
vitalybuka created this revision.
vitalybuka added reviewers: eugenis, kda, rnk.
Herald added a reviewer: bollu.
Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe,
cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,
Joonsoo, liufengdb, aartbi