[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

vabridgers updated this revision to Diff 421519. vabridgers added a comment. add option, retain legacy behavior per comments. update rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

vabridgers added a comment. Ahhh, I see - thanks for the references and discussion. I'll craft a patch to comprehend the use case and user-facing option, and post for review. We'll see how it goes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

steakhal added a comment. In D122841#3431617 , @NoQ wrote: > I looked up the history. I believe this refers to > https://clang.llvm.org/docs/LanguageExtensions.html#memory-references-to-specified-segments: > >> Annotating a pointer with address space #25

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

NoQ added a comment. I looked up the history. I believe this refers to https://clang.llvm.org/docs/LanguageExtensions.html#memory-references-to-specified-segments: > Annotating a pointer with address space #256 causes it to be code generated > relative to the X86 GS segment register, address sp

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

vabridgers added a comment. @steakhal, good question. Digging into the change archaeology, I see this change was made by Anna Zaks in Jan 2016 - see commit header below. There's no reference to a review with comments, and I don't know how to find those if they exist, perhaps @NoQ could help wit

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

steakhal added a comment. Couls you please provide some context about why did we have this suppression in the first place? Other than that, I'm on board with this, but we should really investigate the historical reasons why we had this. If it turns out to be a valid usecase, but a rather speci

[PATCH] D122841: [analyzer] Consider all addrspaces in null dereference check

vabridgers created this revision. vabridgers added reviewers: NoQ, steakhal, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested review