[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

This revision was automatically updated to reflect the committed changes. Closed by commit rG3566bbe62f2e: [analyzer] Add option for AddrSpace in core.NullDereference check (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 424752. vabridgers added a comment. add back amdgcn cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs/analyzer/checkers.rst clang/include

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers marked an inline comment as done. vabridgers added a comment. I believe all comments have been addressed. After discussion with @steakhal, we're leaning towards removing the DefaultBool class and refactoring in favor of the language native bool type - mainly because DefaultBool doesn'

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 424711. vabridgers added a comment. Update test cases, address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs/analyzer/checkers.rst

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers marked 3 inline comments as done. vabridgers added a comment. The two small issues are addressed, I think the only outstanding issue is the question about the test case. Please let me know a preference and I'll implement accordingly. Best! Repository: rG LLVM Github Monorepo CHAN

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 421759. vabridgers added a comment. This revision is now accepted and ready to land. update per @steakhal's latest comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers planned changes to this revision. vabridgers added a comment. Thanks for the the comments. I'll make the changes and resubmit. Please let me know your preferences for the test case (default vs pinned x86 or same). Best! Comment at: clang/lib/StaticAnalyzer/Checkers

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. No major issues left. Comment at: clang/lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp:331 + auto *Chk = mgr.registerChecker(); + // auto *Chk = mgr.getChecker(); +

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers marked 3 inline comments as done. vabridgers added a comment. I believe all points have been addressed. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 421706. vabridgers added a comment. update per @steakhal's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs/analyzer/checkers.rst cla

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers added a comment. I'll address, thanks for the comments. Comment at: clang/docs/analyzer/checkers.rst:69-74 +Check for dereferences of null pointers. This checker specifically does +not report null pointer dereferences for x86 and x86-64 targets when the +address spac

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

steakhal added inline comments. Comment at: clang/docs/analyzer/checkers.rst:69-74 +Check for dereferences of null pointers. This checker specifically does +not report null pointer dereferences for x86 and x86-64 targets when the +address space is 256 (x86 GS Segment), 257 (x86 F

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 421521. vabridgers edited the summary of this revision. vabridgers added a comment. clean up a few debug edits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 File