[PATCH] D122766: [clang] Add the flag -ffile-reproducible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6398f3f2e904: [clang] Add the flag -ffile-reproducible (authored by ayzhao, committed by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 ___ cfe-commits mailing list cfe-comm

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

ayzhao updated this revision to Diff 428139. ayzhao added a comment. Clarify --fno-file-reproducible HelpText Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/include/clang/Basic/LangOptions

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. I still wish this could just be the default behavior, but this flag seems a good compromise. LGTM (but please wait for Aaron too) Comment at: clang/include/clang/Driver/Options

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

ayzhao updated this revision to Diff 428121. ayzhao marked 4 inline comments as done. ayzhao added a comment. code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/include/cl

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Options.td:3020-3023 +HelpText<"remap file source paths in debug info, predefined preprocessor macros and __builtin_FILE(). Implies -ffile-reproducible.">; def fmacro_prefix_map_EQ : Joined<["-"]

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

ayzhao added a comment. In D122766#3450348 , @dexonsmith wrote: > In D122766#3450298 , @ayzhao wrote: > >> So, the general consensus seems to be that we should use backslashes when >> targeting Windows. >> >> I

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

ayzhao updated this revision to Diff 427774. ayzhao added a comment. another missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/include/clang/Basic/LangOptions.h clang/includ

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

ayzhao updated this revision to Diff 427773. ayzhao added a comment. missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/include/clang/Basic/LangOptions.h clang/include/clang/