[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

uabelho added a comment. In D122734#3509187 , @yaxunl wrote: > In D122734#3509096 , @yaxunl wrote: > >> In D122734#3508294 , @uabelho >> wrote: >> >>> Hi, >>> >>> I notic

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl added a comment. In D122734#3509096 , @yaxunl wrote: > In D122734#3508294 , @uabelho wrote: > >> Hi, >> >> I noticed when compiling with gcc 9.3.0 that we get a bunch of new warnings >> with this patch: >>

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl marked an inline comment as done. yaxunl added a comment. In D122734#3508294 , @uabelho wrote: > Hi, > > I noticed when compiling with gcc 9.3.0 that we get a bunch of new warnings > with this patch: > > [1/351] Building CXX object > tools/clan

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

uabelho added a comment. Hi, I noticed when compiling with gcc 9.3.0 that we get a bunch of new warnings with this patch: [1/351] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/MicrosoftCXXABI.cpp.o ../../clang/lib/AST/MicrosoftCXXABI.cpp:57:12: warning: 'virtual unsig

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:682 +/// Current name mangling is for device name in host compilation. +bool MangleDeviceNameInHostCompilation = false; + } CUDANameMangleCtx;

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

rnk added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:682 +/// Current name mangling is for device name in host compilation. +bool MangleDeviceNameInHostCompilation = false; + } CUDANameMangleCtx; yaxunl wrote: > rnk wrote: > > It d

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11d3e31c60bd: [CUDA][HIP] Fix mangling number for local struct (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Mon

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122734/new/ https://reviews.llvm.org/D122734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl updated this revision to Diff 424688. yaxunl marked 5 inline comments as done. yaxunl added a comment. Revised by Artem's and Reid's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122734/new/ https://reviews.llvm.org/D122734 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl marked 7 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:682 +/// Current name mangling is for device name in host compilation. +bool MangleDeviceNameInHostCompilation = false; + } CUDANameMangleCtx;

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

tra added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11760-11763 + auto Cutoff = [](unsigned V) { return V > 1 ? V : 1; }; + if (CUDANameMangleCtx.MangleDeviceNameInHostCompilation) +return Cutoff(Res >> 16); + return Cutoff(Res & 0x); r

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

rnk added inline comments. Herald added a subscriber: mattd. Comment at: clang/include/clang/AST/ASTContext.h:682 +/// Current name mangling is for device name in host compilation. +bool MangleDeviceNameInHostCompilation = false; + } CUDANameMangleCtx; I

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

tra added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11760-11763 + auto Cutoff = [](unsigned V) { return V > 1 ? V : 1; }; + if (CUDANameMangleCtx.MangleDeviceNameInHostCompilation) +return Cutoff(Res >> 16); + return Cutoff(Res & 0x); I

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl updated this revision to Diff 422001. yaxunl retitled this revision from "[HIP] Fix mangling number for local struct" to "[CUDA][HIP] Fix mangling number for local struct". yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: carlosgalvezp. Use Ita