Re: [PATCH] D12271: [X86] Expose the various _rot intrinsics on non-MS platforms

2015-08-25 Thread Michael Kuperstein via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245923: [X86] Expose the various _rot intrinsics on non-MS platforms (authored by mkuper). Changed prior to commit: http://reviews.llvm.org/D12271?vs=32925&id=33050#toc Repository: rL LLVM http://re

Re: [PATCH] D12271: [X86] Expose the various _rot intrinsics on non-MS platforms

2015-08-24 Thread Sean Silva via cfe-commits
silvas added a subscriber: silvas. silvas added a comment. In http://reviews.llvm.org/D12271#231204, @rnk wrote: > This looks good. > > As a larger issue, LLVM fast isel definitely won't pattern match this series > of shifts and selects to rotl at -O0. There are some users who want > branchless

Re: [PATCH] D12271: [X86] Expose the various _rot intrinsics on non-MS platforms

2015-08-24 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. This looks good. As a larger issue, LLVM fast isel definitely won't pattern match this series of shifts and selects to rotl at -O0. There are some users who want branchless constant time rotates re

[PATCH] D12271: [X86] Expose the various _rot intrinsics on non-MS platforms

2015-08-23 Thread Michael Kuperstein via cfe-commits
mkuper created this revision. mkuper added reviewers: majnemer, rnk. mkuper added a subscriber: cfe-commits. _rotl, _rotwl and _lrotl (and their right-shift counterparts) are official x86 intrinsics, and should be supported regardless of environment. This is in contrast to _rotl8, _rotl16, and _r