bulbazord closed this revision.
bulbazord added a comment.
Gah, forgot to add the phabricator link to the commit message. I added the
commit object to this diff, hopefully people can track it down the review if
needed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122691/new/
https://
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Great, thanks for adding the test case!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122691/new/
https://reviews.llvm.org/D122691
___
bulbazord updated this revision to Diff 423437.
bulbazord edited the summary of this revision.
bulbazord added a comment.
Herald added a subscriber: mgorny.
Added a test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122691/new/
https://reviews.llvm.org/D122691
Files:
clang/include/cl
arphaman added a comment.
The change itself LGTM.
It would be really good if we can have a unit test that tests the new API when
it lands, to ensure that this is tested in LLVM-project itself , in addition to
Swift. Do you think it's possible to write a unit tests that constructs a
compiler in
plotfi added subscribers: rjmccall, plotfi.
plotfi added a comment.
@rjmccall would you be able to review this patch? What do you think of this
approach? This change is to support C++-Interop on the Swift side.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
bulbazord created this revision.
bulbazord added a reviewer: arphaman.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Motivation: The intent here is for use in Swift.
When building a clang module for
