[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 added a comment. In D122683#3668423 , @jhuber6 wrote: > In D122683#3668412 , @mgorny wrote: > >> I'm sorry for noticing it this late but this change seems to have broken the >> test on 32-bit x86: > > See

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 added a comment. In D122683#3668412 , @mgorny wrote: > I'm sorry for noticing it this late but this change seems to have broken the > test on 32-bit x86: Seems to be a difference in the alignment, I'm not sure why this changes though because th

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

mgorny added a comment. I'm sorry for noticing it this late but this change seems to have broken the test on 32-bit x86: FAIL: Clang :: Frontend/embed-object.ll (8280 of 15613) TEST 'Clang :: Frontend/embed-object.ll' FAILED Script: -- : 'RUN:

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG984a0dc38655: [OpenMP] Use new offloading binary when embedding offloading images (authored by jhuber6). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 ___

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 423176. jhuber6 added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jdoerfert added inline comments. Comment at: clang/test/Frontend/embed-object.ll:6 +; CHECK: @[[OBJECT:.+]] = private constant [120 x i8] c"\10\FF\10\AD{{.*}}\00", section ".llvm.offloading", align 8 +; CHECK: @llvm.compiler.used = appending global [2 x i8*] [i8* @x, i8* getele

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 422580. jhuber6 added a comment. Fix test after move to opaque pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOpt

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 422547. jhuber6 added a comment. Cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/Back

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 419490. jhuber6 added a comment. Fixing unrelated formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOption

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: ormris, dexonsmith, guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,