[PATCH] D122681: Don't diagnostic atomic object access as UB in an unevaluated context

2022-03-30 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the reviews, I've commit in cf4a67bcbbb109347b1e2d6cedf69bae142a182f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D122681: Don't diagnostic atomic object access as UB in an unevaluated context

2022-03-29 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D122681#3414901 , @aaron.ballman wrote: > In D122681#3414900 , @erichkeane > wrote: > >> Ah! Release notes! > > I didn't add one because this is augmenting https://reviews.llvm.o

[PATCH] D122681: Don't diagnostic atomic object access as UB in an unevaluated context

2022-03-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D122681#3414900 , @erichkeane wrote: > Ah! Release notes! I didn't add one because this is augmenting https://reviews.llvm.org/D122656 which already added the release note. :-) Repository: rG LLVM Github Monorepo

[PATCH] D122681: Don't diagnostic atomic object access as UB in an unevaluated context

2022-03-29 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Ah! Release notes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122681/new/ https://reviews.llvm.org/D122681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D122681: Don't diagnostic atomic object access as UB in an unevaluated context

2022-03-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, erichkeane, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. We started diagnosing this situation with a more clear diagnostic message, but