This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc1e614c8eb50: [clang][DR] Test and mark DR1305 as complete
(authored by zero9178).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
cor3ntin added a comment.
Looks great!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122674/new/
https://reviews.llvm.org/D122674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
zero9178 updated this revision to Diff 418941.
zero9178 added a comment.
Address reviewers comments: Group test nicely with the other dr namespaces.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122674/new/
https://reviews.llvm.org/D122674
Files:
clang/test/CXX/drs/dr13xx.cpp
clang
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122674/new/
https://reviews.llvm.org/D122674
__
cor3ntin added a comment.
Looks good except I think it makes more sense to put the new test just before
the first test
Comment at: clang/test/CXX/drs/dr13xx.cpp:25
}
namespace dr1310 { // dr1310: 5
I think it would make more sense to put the new test here
zero9178 created this revision.
zero9178 added a reviewer: clang-language-wg.
Herald added a project: All.
zero9178 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
DR: http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1305
This
