[PATCH] D122673: Add kcfi_unchecked attribute

2022-04-13 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen abandoned this revision. samitolvanen added a comment. Alright, thanks for the feedback everyone! I'll abandon this patch and look into adding a built-in function instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122673/new/ http

[PATCH] D122673: Add kcfi_unchecked attribute

2022-04-11 Thread Joao Moreira via Phabricator via cfe-commits
joaomoreira added a comment. > In the previous discussion, @joaomoreira pointed out that this is very > similar to `nocf_check` and proposed reusing that attribute. In an offline > discussion, @pcc was concerned that an attribute may not be the right > approach here and suggested a `__builti

[PATCH] D122673: Add kcfi_unchecked attribute

2022-04-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D122673#3443518 , @samitolvanen wrote: > In D122673#3443498 , @aaron.ballman > wrote: > >> I tend to be very wary of modifying the type system with attributes -- >> questions a

[PATCH] D122673: Add kcfi_unchecked attribute

2022-04-11 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen added a comment. In D122673#3443498 , @aaron.ballman wrote: > I tend to be very wary of modifying the type system with attributes -- > questions always arise of what the type system effects are of the attribute. > e.g., does it impact over

[PATCH] D122673: Add kcfi_unchecked attribute

2022-04-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D122673#3414650 , @samitolvanen wrote: > Note that this was split from D119296 . > > In the previous discussion, @joaomoreira pointed out that this is very > similar to `nocf_check` an

[PATCH] D122673: Add kcfi_unchecked attribute

2022-03-29 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen added a comment. Note that this was split from D119296 . In the previous discussion, @joaomoreira pointed out that this is very similar to `nocf_check` and proposed reusing that attribute. In an offline discussion, @pcc was concerned that an attr

[PATCH] D122673: Add kcfi_unchecked attribute

2022-03-29 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen created this revision. samitolvanen added reviewers: aaron.ballman, pcc, nickdesaulniers, ardb, kees, joaomoreira. Herald added subscribers: jdoerfert, martong. Herald added a project: All. samitolvanen requested review of this revision. Herald added a project: clang. Herald added a s