[PATCH] D122611: [clang][extract-api] Add support for macros

dang closed this revision. dang added a comment. 529a0570f7e8c5144bd3ad057e43f00e3af58d1b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122

[PATCH] D122611: [clang][extract-api] Add support for macros

thakis added a comment. My windows bot cycled green, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D122611: [clang][extract-api] Add support for macros

dang added a comment. @thakis I am UK based so I am logging off as it's 9pm over here. The fix I committed has fixed the issue on other buildbots that were failing due to this. If it still fails on Windows, would you be able to revert the change for me? Repository: rG LLVM Github Monorepo C

[PATCH] D122611: [clang][extract-api] Add support for macros

dang added a comment. Committed a revert of the changes in that particular function in commit 985eaa1a3da2a1b88ea70a65ffd5783aa82ea65e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D122611: [clang][extract-api] Add support for macros

dang added a comment. I have what should be a NFC fix that should fix the issue, just checking everything still works and will commit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 _

[PATCH] D122611: [clang][extract-api] Add support for macros

thakis added a comment. Looks like either this or your other commit at the same time broke tests on windows: http://45.33.8.238/win/55345/step_7.txt Please take a look, and revert for now if it takes a while to fix. (Also, please add a "Differential Revision: https://reviews.llvm.org/D122611";

[PATCH] D122611: [clang][extract-api] Add support for macros

dyung added a comment. This change is causing 9 test failures on a buildbot, can you please take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/19441 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D122611: [clang][extract-api] Add support for macros

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 ___

[PATCH] D122611: [clang][extract-api] Add support for macros

dang updated this revision to Diff 419207. dang marked 3 inline comments as done. dang added a comment. Update with code review feedback and the rebased code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D12261

[PATCH] D122611: [clang][extract-api] Add support for macros

zixuw added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:334 + using RecordMap = llvm::MapVector>; + /// /// Get the target triple for the ExtractAPI invocation. Extra/should-be-empty line here? Comment at: clang/lib/E

[PATCH] D122611: [clang][extract-api] Add support for macros

dang updated this revision to Diff 418948. dang added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 Files: clang/include/clang/ExtractAPI/API.h clang/include/clan

[PATCH] D122611: [clang][extract-api] Add support for macros

dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:446-457 +void ExtractAPIAction::EndSourceFileAction() { + if (!OS) +return; + + // Setup a SymbolGraphSerializer to write out collected API information

[PATCH] D122611: [clang][extract-api] Add support for macros

dang marked 7 inline comments as done. dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:117 - GlobalRecord(GVKind Kind, StringRef Name, StringRef USR, PresumedLoc Loc, + GlobalRecord(StringRef Name, GVKind Kind, StringRef USR, PresumedLoc Loc,

[PATCH] D122611: [clang][extract-api] Add support for macros

zixuw added inline comments. Comment at: clang/include/clang/ExtractAPI/Serialization/SymbolGraphSerializer.h:22 #include "clang/ExtractAPI/Serialization/SerializerBase.h" +#include "clang/Lex/PreprocessingRecord.h" #include "llvm/Support/JSON.h" Why do we nee

[PATCH] D122611: [clang][extract-api] Add support for macros

zixuw added a comment. Still going through the declaration fragments builder and `ExtractAPIVisitor/Consumer/Action` changes, but it seems that the patch needs a rebase onto the latest main right now as it's missing several already landed changes. Comment at: clang/include/c

[PATCH] D122611: [clang][extract-api] Add support for macros

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To achieve this we hook into the preprocessor during the ExtractAPIAction