[PATCH] D122544: Utilize comparison operation implemented in APInt

SimplyDanny marked 3 inline comments as done. SimplyDanny added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:175 // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: suspicious usage of sizeof pointer 'sizeof(T)/sizeof(T)' -int

[PATCH] D122544: Utilize comparison operation implemented in APInt

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:175 // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: suspicious usage of sizeof pointer 'sizeof(T)/sizeof(T)' -int Test3() { return Foo<42>() + Bar(); } +temp

[PATCH] D122544: Utilize comparison operation implemented in APInt

SimplyDanny added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:175 // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: suspicious usage of sizeof pointer 'sizeof(T)/sizeof(T)' -int Test3() { return Foo<42>() + Bar(); } +templa

[PATCH] D122544: Utilize comparison operation implemented in APInt

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:175 // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: suspicious usage of sizeof pointer 'sizeof(T)/sizeof(T)' -int Test3() { return Foo<42>() + Bar(); } +temp

[PATCH] D122544: Utilize comparison operation implemented in APInt

aaronpuchert added a comment. Note that `__int128_t` is not available everywhere, generally only on 64-bit platforms. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:175 // CHECK-MESSAGES: :[[@LINE-1]]:28: warning: suspicious usage of si

[PATCH] D122544: Utilize comparison operation implemented in APInt

aaron.ballman added a comment. In D122544#3412568 , @SimplyDanny wrote: > In D122544#3411226 , @aaron.ballman > wrote: > >> LGTM! Can you also add a release note for the fix? >> >> I'm happy to land this on your

[PATCH] D122544: Utilize comparison operation implemented in APInt

SimplyDanny added a comment. In D122544#3411226 , @aaron.ballman wrote: > LGTM! Can you also add a release note for the fix? > > I'm happy to land this on your behalf if you'd prefer, but given that you've > had several quality commits already, you migh

[PATCH] D122544: Utilize comparison operation implemented in APInt

This revision was automatically updated to reflect the committed changes. Closed by commit rGff60af91ac0b: [clang-tidy] Utilize comparison operation implemented in APInt (authored by SimplyDanny). Changed prior to commit: https://reviews.llvm.org/D122544?vs=418450&id=418709#toc Repository: r

[PATCH] D122544: Utilize comparison operation implemented in APInt

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Can you also add a release note for the fix? I'm happy to land this on your behalf if you'd prefer, but given that you've had several quality commits already, you might wan

[PATCH] D122544: Utilize comparison operation implemented in APInt

SimplyDanny created this revision. SimplyDanny added a reviewer: njames93. Herald added a subscriber: carlosgalvezp. Herald added a project: All. SimplyDanny requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This is a fix for #539