This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG596752863e27: [clang][ASTImporter] Fix an import error
handling related bug. (authored by balazske).
Repository:
rG LLVM Github Monorepo
CHANGES
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Very good! Thanks for the update!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122525/new/
https://reviews.llvm.org/D122525
balazske updated this revision to Diff 422139.
balazske added a comment.
Created a common place for the `DeclContext` child error handling code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122525/new/
https://reviews.llvm.org/D122525
Files:
cl
martong added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:8792-8794
+if (!isa(FromDi))
+ if (auto *FromDiDC = dyn_cast(FromDi))
+if (FromDiDC->containsDecl(PrevFromDi))
balazske wrote:
> martong wrote:
> > We should ele
balazske added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:8792-8794
+if (!isa(FromDi))
+ if (auto *FromDiDC = dyn_cast(FromDi))
+if (FromDiDC->containsDecl(PrevFromDi))
martong wrote:
> We should elevate this logic and
martong added a comment.
Related: https://reviews.llvm.org/D112132
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122525/new/
https://reviews.llvm.org/D122525
___
cfe-commits mailing list
cfe-commits@list
martong added a comment.
Nice catch!
Comment at: clang/lib/AST/ASTImporter.cpp:8789-8791
+// The import path contains child nodes first.
+// (Parent-child relationship is used here in sense of import
+// dependency.)
I think, this commen
balazske created this revision.
Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Herald added a project: All.
balazske requested review of this revision.
Herald added a project: clang.
Herald added a subs
