dcoughlin added inline comments.
Comment at: test/Analysis/array-struct-region.cpp:128
@@ +127,3 @@
+#if __cplusplus
+ clang_analyzer_eval((void *)&PFONew->secondField != (void *)&PFONew); //
expected-warning{{TRUE}}
+#endif
ismailp wrote:
> I might be missing s
ismailp marked 3 inline comments as done.
Comment at: test/Analysis/array-struct-region.cpp:128
@@ +127,3 @@
+#if __cplusplus
+ clang_analyzer_eval((void *)&PFONew->secondField != (void *)&PFONew); //
expected-warning{{TRUE}}
+#endif
I might be missing something
ismailp updated this revision to Diff 36123.
ismailp added a comment.
- Don't try to calculate field offset for Objective-C instance variables
- Added test for Objective-C instance variables
- Added a non-null pointer in test
http://reviews.llvm.org/D12251
Files:
lib/StaticAnalyzer/Core/Store
dcoughlin requested changes to this revision.
dcoughlin added a comment.
This revision now requires changes to proceed.
Thanks for the patch Ismail! Some comments inline.
Comment at: lib/StaticAnalyzer/Core/Store.cpp:408
@@ +407,3 @@
+if (!Base.isZeroConstant()) {
+ if
ismailp added a comment.
Ping!
http://reviews.llvm.org/D12251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp added a comment.
Ping!
http://reviews.llvm.org/D12251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp created this revision.
ismailp added reviewers: krememek, zaks.anna.
ismailp added a subscriber: cfe-commits.
`StoreManager::getLValueFieldOrIvar` should return loc as
base + field-offset, instead of just base.
http://reviews.llvm.org/D12251
Files:
lib/StaticAnalyzer/Core/Store.cpp
t
