[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c6d32ec6cdb: [OpenMP] Make Ctor / Dtor functions have external visibility (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

jhuber6 added a comment. In D122504#3408947 , @JonChesterfield wrote: > Nice, thanks. Wonder if we want protected visibility as well. I'm not actually sure what having protected visibility would do considering it's not applied with `-fvisibility=protec

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice, thanks. Wonder if we want protected visibility as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122504/new/ https:

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

jhuber6 updated this revision to Diff 418321. jhuber6 added a comment. Herald added a subscriber: jvesely. Changing approach, we should optionally use internal linkage for the ctor creation function since it's not correct to add the internal linkage attributes and then make it external. Also remov

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, ABataev. Herald added subscribers: asavonic, guansong, tpr, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a pr