[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

2022-03-28 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe334f044cdb5: [libTooling] Support TransformerResult in consumer callbacks (authored by li.zhe.hua, committed by ymandel). Repository: rG L

[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

2022-03-25 Thread Eric Li via Phabricator via cfe-commits
li.zhe.hua marked 2 inline comments as done. li.zhe.hua added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:126-128 +template +std::enable_if_t::value, void> +assertMetadataSet(const transformer::RewriteRuleWith &) {} ymandel

[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

2022-03-25 Thread Eric Li via Phabricator via cfe-commits
li.zhe.hua updated this revision to Diff 418316. li.zhe.hua added a comment. Fix for comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122499/new/ https://reviews.llvm.org/D122499 Files: clang/include/clang/Tooling/Transformer/Transformer.

[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

2022-03-25 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:126-128 +template +std::enable_if_t::value, void> +assertMetadataSet(const transformer::RewriteRuleWi

[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

2022-03-25 Thread Eric Li via Phabricator via cfe-commits
li.zhe.hua updated this revision to Diff 418295. li.zhe.hua added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122499/new/ https://reviews.llvm.org/D122499 Files: clang/include/clang/Tooling/Transformer/Transformer.h c

[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

2022-03-25 Thread Eric Li via Phabricator via cfe-commits
li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support `TransformerResult` in the consumer callback, which allows generic code