This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG15bf0e567375: [clang][extract-api] Use correct language info
from inputs (authored by zixuw).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
dang accepted this revision.
dang added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122495/new/
https://reviews.llvm.org/D122495
___
cf
zixuw updated this revision to Diff 418724.
zixuw marked an inline comment as done.
zixuw added a comment.
Address review issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122495/new/
https://reviews.llvm.org/D122495
Files:
clang/include/cla
zixuw marked 2 inline comments as done.
zixuw added inline comments.
Comment at: clang/include/clang/ExtractAPI/API.h:312
- /// Get the language options used to parse the APIs.
- const LangOptions &getLangOpts() const { return LangOpts; }
+ /// Get the language by the APIs.
dang added inline comments.
Comment at: clang/include/clang/ExtractAPI/API.h:312
- /// Get the language options used to parse the APIs.
- const LangOptions &getLangOpts() const { return LangOpts; }
+ /// Get the language by the APIs.
+ Language getLanguage() const { return
zixuw created this revision.
Herald added a reviewer: dang.
Herald added a project: All.
zixuw requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The current way of getting the `clang::Language` from `LangOptions` does
not handle Objective-C c
