[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

This revision was automatically updated to reflect the committed changes. Closed by commit rG4df69c1ff19f: [ARM] Make testcase warning pattern match more specific (authored by rs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122487/new/ https://re

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. In D122487#3408425 , @rs wrote: > @tstellar thanks for the review. I can't really think of any other way to > test this. I'll wait till Monday if

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

rs added a comment. @tstellar thanks for the review. I can't really think of any other way to test this. I'll wait till Monday if no one else has suggested anything else then I'll commit it. Thanks again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

tstellar added a comment. The reason I used a minimal check string is because if the warning text changes at all, then the test becomes useful (this is the downside of using -NOT). I wonder if there is another way to test this that might be robust? If not, then I think this change is fine.

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

rs created this revision. rs added reviewers: tstellar, lenary. Herald added a subscriber: kristof.beyls. Herald added a project: All. rs requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make the warning more specific as downstream compilers