[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb389354b2857: [Clang][PowerPC] Add max/min intrinsics to Clang and PPC backend (authored by tingwang). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf accepted this revision as: qiucf. qiucf added a comment. This revision is now accepted and ready to land. Looks good to me in my side. Thanks for implementing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122478/new/ https://reviews.llvm.

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang marked an inline comment as done. tingwang added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9897 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding : E

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 419704. tingwang added a comment. Update based on comments: (1) Reuse diag error message. (2) Update clang test case for those diag messages. (3) Add TODO comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9897 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding : Error< Use `err_target_unsuppo

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:192 + [llvm_float_ty, llvm_float_ty, llvm_float_ty, llvm_vararg_ty], + [IntrNoMem]>; } qiucf wrote: > Will we support `llvm_f128_ty`? I'm afr

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 418544. tingwang marked 11 inline comments as done. tingwang added a comment. Update based on Chaofan's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122478/new/ https://reviews.llvm.org/D122478

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 418509. tingwang added a comment. Update test case to show that we need D122462 to fix the crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122478/new/ https://reviews.l

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9899 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding : Error< Can we re-use `err_type

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang updated this revision to Diff 418485. tingwang added a comment. Option -mlong-double-128 is not supported on AIX currently, and clang fails due to type mismatch in the fe case. Add check logic to print diag message in this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang added a comment. Since this is compatibility support, I'm trying to match the result from XLC in scenarios where there is all kinds of QNaN, SNaN, +/-Infinity, +/-ZERO. Currently maxfl and maxfs still give different result compared with XLC in above scenario. This is one thing I'm stil

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

tingwang created this revision. tingwang added reviewers: PowerPC, jsji, nemanjai, shchenz. tingwang added a project: LLVM. Herald added subscribers: kbarton, hiraditya. Herald added a project: All. tingwang requested review of this revision. Herald added a project: clang. Herald added subscribers: