[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. zixuw marked an inline comment as done. Closed by commit rG9b36e126fdb1: [clang][extract-api] Add Objective-C interface support (authored by zixuw). Repository: rG L

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang accepted this revision. dang added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:642-648 +// Instantiate template for FunctionDecl. +template FunctionSignature +DeclarationFragmentsBuilder::getFunc

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

zixuw marked an inline comment as done. zixuw added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:642-648 +// Instantiate template for FunctionDecl. +template FunctionSignature +DeclarationFragmentsBuilder::getFunctionSignature(const FunctionDecl *);

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang requested changes to this revision. dang added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:660 + +// Subheading of an Objective-C method is a `+` or `-` sign indicating whether +// it's a class met

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:245 +if (const auto *SuperClassDecl = Decl->getSuperClass()) { + SuperClass.Name = SuperClassDecl->getObjCRuntimeNameAsString(); + SuperClass.USR = API.recordUSR(SuperClassDecl); ---

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:642-648 +// Instantiate template for FunctionDecl. +template FunctionSignature +DeclarationFragmentsBuilder::getFunctionSignature(const FunctionDecl *); + +// Instantiate template for ObjCMethod

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:245 +if (const auto *SuperClassDecl = Decl->getSuperClass()) { + SuperClass.Name = SuperClassDecl->getObjCRuntimeNameAsString(); + SuperClass.USR = API.recordUSR(SuperClassDecl); ---

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:245 +if (const auto *SuperClassDecl = Decl->getSuperClass()) { + SuperClass.Name = SuperClassDecl->getObjCRuntimeNameAsString(); + SuperClass.USR = API.recordUSR(SuperClassDecl); --

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

zixuw updated this revision to Diff 418738. zixuw marked 4 inline comments as done. zixuw added a comment. - Address review comments: - Use template to reuse logic for building function signatures for FunctionDecl and ObjCMethodDecl. - Move the change of `objc_interface.m` test in this patch fr

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:375 + case APIRecord::RK_ObjCIvar: +Kind["identifier"] = AddLangPrefix("ivar"); +Kind["displayName"] = "Instance Variable"; this should probably be more

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:624-660 FunctionSignature DeclarationFragmentsBuilder::getFunctionSignature(const FunctionDecl *Func) { FunctionSignature Signature; for (const auto *Param : Func->parameters()) {

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

zixuw updated this revision to Diff 418342. zixuw added a comment. No code change, amend commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122446/new/ https://reviews.llvm.org/D122446 Files: clang/include/clang/ExtractAPI/API.h cla

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

zixuw updated this revision to Diff 418286. zixuw added a comment. Move the `Language` fix out into a separate patch: D122495 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122446/new/ https://reviews.llvm.org/D12

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add support for Objective-C interface declarations in ExtractAPI. - Use `clang::Language` for l