saudi added inline comments.
Herald added a subscriber: ributzka.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:487
+if (!llvm::sys::path::has_extension(CurrentO))
+ LastO = (CurrentO + ".obj").str();
+else
jansvoboda11 updated this revision to Diff 438367.
jansvoboda11 added a comment.
Code review feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122385/new/
https://reviews.llvm.org/D122385
Files:
clang/test/ClangScanDeps/cl-output.c
clang/
saudi added a comment.
Nice! It's much more straightforward now, the reverse iteration was pretty
confusing.
Thanks!
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:478
+ if (Arg == "-Xclang")
+++I;
+
A test for boundary
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith, saudi.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
One goal of the ad-hoc command line argument parsing i
