angelgarcia closed this revision.
angelgarcia added a comment.
Committed revision 245703.
http://reviews.llvm.org/D12231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D12231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
angelgarcia updated this revision to Diff 32818.
angelgarcia added a comment.
Fix comments: change warning message and minor fixes.
http://reviews.llvm.org/D12231
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseAutoCheck.cpp
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:45
@@ +44,3 @@
+
+ // The following test is based on DeclPrinter::VisitVarDecl() or find if an
+ // initializer is implicit or not.
I can't parse it with 'or'. Did you mean something
angelgarcia updated this revision to Diff 32816.
angelgarcia added a comment.
Apply clang-format to the code.
http://reviews.llvm.org/D12231
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseAutoCheck.cpp
clang-tidy/modernize
angelgarcia updated this revision to Diff 32815.
angelgarcia marked 10 inline comments as done.
angelgarcia added a comment.
Fix comments.
I did not include the 'hasDeclaration()" call in the 'standardIterator'
function because its return type is
internal::PolymorphicMatcherWithParam1< internal:
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:45
@@ +44,3 @@
+
+ // The following test is based on DeclPrinter::VisitVarDecl() o find if an
+ // initializer is implicit o not.
s/o find/to find/?
s/o not/or not/?
==
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: cfe-commits, klimek.
angelgarcia changed the visibility of this Differential Revision from "Public
(No Login Required)" to "All Users".
Migrate UseAuto from clang-modernize to clang-tidy.
http
