[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36d4e84427a7: [clang][dataflow] Fix handling of base-class fields. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel updated this revision to Diff 419751. ymandel added a comment. tweak comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122273/new/ https://reviews.llvm.org/D122273 Files: clang/include/clang/Analysis/FlowSensitive/StorageLocation.h

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/StorageLocation.h:59-60 /// can be traced independently by abstract interpretation. For example: a -/// struct with public members. +/// struct with public members. Note that the corresponding

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel updated this revision to Diff 419744. ymandel marked 5 inline comments as done. ymandel added a comment. add clarifying comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122273/new/ https://reviews.llvm.org/D122273 Files: clang/inclu

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel updated this revision to Diff 419743. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122273/new/ https://reviews.llvm.org/D122273 Files: clang/include/clang/Analysis/FlowSensitive/StorageLocation.

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/StorageLocation.h:59-60 /// can be traced independently by abstract interpretation. For example: a -/// struct with public members. +/// struct with public members

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:185 + // base classes, because they are not visible in derived classes. + getFieldsFromClassHierarchy(Base.getType(), /*IgnorePrivateF

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel added a comment. Thanks for the reviews. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:185 + // base classes, because they are not visible in derived classes. + getFieldsFromClassHierarchy(Base.getType(), /*IgnorePrivateFields=*/true, +

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel updated this revision to Diff 419499. ymandel marked 5 inline comments as done. ymandel added a comment. adjusted test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122273/new/ https://reviews.llvm.org/D122273 Files: clang/include/clang/

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel updated this revision to Diff 419496. ymandel added a comment. address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122273/new/ https://reviews.llvm.org/D122273 Files: clang/include/clang/Analysis/FlowSensitive/Storage

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:185 + // base classes, because they are not visible in derived classes. + getFieldsFromClassHierarchy(Base.getType(), /*IgnorePrivateFields=*/true, +

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:168 +static void +getFieldsFromClassHierarchy(QualType Type, bool IgnorePrivateFields, +

[PATCH] D122273: [clang][dataflow] Fix handling of base-class fields

ymandel created this revision. ymandel added reviewers: sgatev, gribozavr2. Herald added subscribers: tschuett, steakhal. Herald added a project: All. ymandel updated this revision to Diff 417906. ymandel added a comment. ymandel updated this revision to Diff 419430. ymandel retitled this revision