hokein added inline comments.
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Forest.h:158
+ size_t nodeCount() const { return NodeCount; }
+ size_t bytes() const { return Arena.getBytesAllocated() + sizeof(this); }
+
RKSimon wrote:
> @hokein Static a
RKSimon added inline comments.
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Forest.h:158
+ size_t nodeCount() const { return NodeCount; }
+ size_t bytes() const { return Arena.getBytesAllocated() + sizeof(this); }
+
@hokein Static analysis is warni
This revision was automatically updated to reflect the committed changes.
Closed by commit rG62d5f254ccd0: [pseudo] Introduce parse forest. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D122139?vs=417225&id=417911#toc
Repository:
rG LLVM Github Monorepo
CHANGES SIN
hokein updated this revision to Diff 417225.
hokein marked 7 inline comments as done.
hokein added a comment.
address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122139/new/
https://reviews.llvm.org/D122139
Files:
clang-tools-
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Forest.h:35
+// trailing array) and have pointers to them. "Children" has different
semantics
+// dependi
hokein updated this revision to Diff 416936.
hokein added a comment.
small tweaks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122139/new/
https://reviews.llvm.org/D122139
Files:
clang-tools-extra/pseudo/include/clang-pseudo/Forest.h
clang-t
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a subscriber: mgorny.
Herald added a project: All.
hokein requested review of this revision.
Herald added a subscriber: alextsao1999.
Herald added a project: clang-tools-extra.
Parse forest is the output of the GLR pars
