ab added a comment.
Thanks Simon! Replaced the FIXMEs with proper tests and committed.
Whenever I have time I'll have a look at the others, filed PR24580.
Repository:
rL LLVM
http://reviews.llvm.org/D12212
___
cfe-commits mailing list
cfe-commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245987: [Headers][X86] Add -O0 assembly tests for avx2
intrinsics. (authored by ab).
Changed prior to commit:
http://reviews.llvm.org/D12212?vs=32732&id=33147#toc
Repository:
rL LLVM
http://reviews.
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM with a suitable FIXME comment. Email me if you want to split the work on
adding this to the other SSE/AVX builtin tests.
http://reviews.llvm.org/D12212
_
RKSimon added a comment.
Definitely like this idea - hopefully it'll make it safer to remove unnecessary
builtins.
Comment at: avx2-builtins-codegen.c:182
@@ -151,1 +181,3 @@
+ // FIXME-CHECK-ASM: vpxor %ymm{{.*}}
+ // FIXME-CHECK-ASM: vandps {{.*}}, %ymm{{.*}}
return _mm2
ab created this revision.
ab added reviewers: spatel, RKSimon.
ab added subscribers: cfe-commits, chandlerc, silvas, qcolombet.
We agreed in D10555 that, as long as we don't affect -O0 codegen too much, it's
OK to use native constructs rather than intrinsics. Let's test that, starting
with AVX2
