This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf6740fe483e9: [clang-format] Indent import statements in
JavaScript. (authored by sstwcw).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
sstwcw updated this revision to Diff 417128.
sstwcw marked an inline comment as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121906/new/
https://reviews.llvm.org/D121906
Files:
clang/lib/Format/UnwrappedLineFormatter.cpp
clang/unittests/F
sstwcw marked an inline comment as done.
sstwcw added inline comments.
Comment at: clang/lib/Format/ContinuationIndenter.cpp:633
(State.Line->Type == LT_PreprocessorDirective ||
State.Line->Type == LT_ImportStatement)) {
Spaces += State.FirstIndent;
--
sstwcw updated this revision to Diff 417125.
sstwcw marked an inline comment as done.
sstwcw added a comment.
remove unnecessary check
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121906/new/
https://reviews.llvm.org/D121906
Files:
clang/lib/Fo
MyDeveloperDay added inline comments.
Comment at: clang/lib/Format/ContinuationIndenter.cpp:633
(State.Line->Type == LT_PreprocessorDirective ||
State.Line->Type == LT_ImportStatement)) {
Spaces += State.FirstIndent;
AfterHash - Could be true
sstwcw marked an inline comment as done.
sstwcw added inline comments.
Comment at: clang/lib/Format/ContinuationIndenter.cpp:631
+ Style.IndentPPDirectives == FormatStyle::PPDIS_AfterHash &&
Previous.is(tok::hash) && State.FirstIndent > 0 &&
(State.Line->Type =
MyDeveloperDay added inline comments.
Comment at: clang/lib/Format/ContinuationIndenter.cpp:631
+ Style.IndentPPDirectives == FormatStyle::PPDIS_AfterHash &&
Previous.is(tok::hash) && State.FirstIndent > 0 &&
(State.Line->Type == LT_PreprocessorDirective ||
---
sstwcw updated this revision to Diff 416456.
sstwcw added a comment.
use `isJavascript`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121906/new/
https://reviews.llvm.org/D121906
Files:
clang/lib/Format/ContinuationIndenter.cpp
clang/lib/Forma
MyDeveloperDay requested changes to this revision.
MyDeveloperDay added a comment.
This revision now requires changes to proceed.
Can you please supply full context diff "Context not available."
Comment at: clang/lib/Format/ContinuationIndenter.cpp:629
int PPColumnCorrection
owenpan added subscribers: HazardyKnusperkeks, krasimir, MyDeveloperDay,
curdeius, owenpan.
owenpan added a comment.
Please add @krasimir @MyDeveloperDay @curdeius @HazardyKnusperkeks to Reviewers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1219
sstwcw created this revision.
sstwcw added a reviewer: clang-format.
sstwcw added a project: clang-format.
Herald added a project: All.
sstwcw requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
[clang-format] Indent import statements in JavaSc
11 matches
Mail list logo