alexfh closed this revision.
alexfh added a comment.
Thanks!
Committed revision 245561.
http://reviews.llvm.org/D12186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer accepted this revision.
bkramer added a reviewer: bkramer.
bkramer added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D12186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
angelgarcia updated this revision to Diff 32688.
angelgarcia added a comment.
Add a test.
http://reviews.llvm.org/D12186
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
test/clang-tidy/Inputs/modernize-loop-convert/structures.h
test/clang-tidy/modernize-loop-convert-extra.cpp
Index: tes
angelgarcia added a comment.
In http://reviews.llvm.org/D12186#228704, @bkramer wrote:
> I meant the code before your change, which calls `StringRef(const char *Str)`
> and completely disallows nullptr. In other words: this change is missing a
> regression test.
You are right, the current tes
bkramer added a comment.
In http://reviews.llvm.org/D12186#228702, @angelgarcia wrote:
> It is allowed as long as you specify that the length is 0.
I meant the code before your change, which calls `StringRef(const char *Str)`
and completely disallows nullptr. In other words: this change is mis
angelgarcia added a comment.
Oooops, copy pasting there was not a good idea. Sorry :(
http://reviews.llvm.org/D12186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
angelgarcia added a comment.
It is allowed as long as you specify that the length is 0.
assert
https://cs.corp.google.com/#piper///depot/google3/third_party/grte/v4_x86/release/usr/grte/v4/include/assert.h&l=85&ct=xref_jump_to_def&cl=GROK&gsn=assert((data
https://cs.corp.google.com/#piper///depo
bkramer added a subscriber: bkramer.
bkramer added a comment.
Is this tested? I'd expect a crash when constructing a StringRef implicitly
from nullptr.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:341
@@ -340,3 +340,3 @@
SourceMgr.getFileID(Range.getEnd()))
-
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added a subscriber: cfe-commits.
angelgarcia changed the visibility of this Differential Revision from "Public
(No Login Required)" to "All Users".
Remove implicit conversion from nullptr to StringRef.
http://re
