[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

jdoerfert added a comment. In D121837#3392346 , @kamaub wrote: > The test cases added with this commit failed on clang-ppc64be-linux-lnt # > 13809 could you > please revert this change, and rec

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

kamaub added a comment. The test cases added with this commit failed on clang-ppc64be-linux-lnt # 13809 could you please revert this change, and recommit with the test case corrected? thank you. Repository: rG LLVM Github Monorepo

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

jdoerfert added a comment. In D121837#3390042 , @thakis wrote: > Looks like this breaks tests: http://45.33.8.238/linux/71358/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I relaxed the check line. Should resolve the pr

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/71358/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121837/new/ https://reviews.llvm.org/D1

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf02550bdd9b7: Reapply "[OpenMP][FIX] Allow device constructors for AMD GPU" (authored by jdoerfert). Changed prior to commit: https://reviews.llvm

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

ronlieb added a comment. i applied it locally and ran bot equiv, looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121837/new/ https://reviews.llvm.org/D121837 ___ cfe-commits mailing list c

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

JonChesterfield accepted this revision. JonChesterfield added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121837/new/ https://reviews.llvm.org/D121837 ___ cfe-commits mailing list cf

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

jdoerfert updated this revision to Diff 416218. jdoerfert added a comment. Fix AS(0) -> AS(0) cast error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121837/new/ https://reviews.llvm.org/D121837 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp cl

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

ronlieb added a comment. Hi Johannes, assert in two of the tests #7 0x5576b8d055e4 llvm::ConstantExpr::getAddrSpaceCast(llvm::Constant*, llvm::Type*, bool) (/work/omp-vega20-0/openmp-offload-amdgpu-runtime/llvm.build/bin/clang-15+0x1e4b5e4) https://lab.llvm.org/buildbot/#/builders/193/bui

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07b176646134: [OpenMP][FIX] Allow device constructors for AMD GPU (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D1218

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121837/new/ https://reviews.llvm.org/D121837

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

jdoerfert created this revision. jdoerfert added a reviewer: JonChesterfield. Herald added subscribers: guansong, bollu, yaxunl, jvesely. Herald added a project: All. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. In AMD