[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

2022-03-17 Thread Matt Devereau via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa9e08bc7c1e5: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select (authored by MattDevereau). Changed prior to commit: https://reviews.llvm.

[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

2022-03-17 Thread Peter Waller via Phabricator via cfe-commits
peterwaller-arm added a comment. In D121792#3388585 , @dmgreen wrote: > Why do we have llvm.aarch64.sve.sel if we are always going to replace it with > a select? Why not remove llvm.aarch64.sve.sel entirely? I'm not the key decisionmaker here, but hopef

[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

2022-03-17 Thread Dave Green via Phabricator via cfe-commits
dmgreen added a comment. Why do we have llvm.aarch64.sve.sel if we are always going to replace it with a select? Why not remove llvm.aarch64.sve.sel entirely? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121792/new/ https://reviews.llvm.org/D1217

[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

2022-03-16 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen accepted this revision. sdesmalen added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:530-531 + IntrinsicInst &II) { + IRBuilder<> Bui

[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

2022-03-16 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau created this revision. MattDevereau added reviewers: peterwaller-arm, paulwalker-arm, DavidTruby, bsmith. Herald added subscribers: ctetreau, psnobl, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. MattDevereau requested review of th