This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rGd41445113bcc: [CUDA][HIP] Fix hostness check with -fopenmp
(authored by yaxunl).
Herald added a project: cla
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:3325-3330
+ /// getCurFunctionDecl - If parsing a lambda, then return the lambda
+ /// declaration if \p AllowLambda is true, otherwise return the function
+ ///
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Sema/Sema.h:3325-3330
+ /// getCurFunctionDecl - If parsing a lambda, then return the lambda
+ /// declaration if \p AllowLambda is true
yaxunl marked an inline comment as done.
yaxunl added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121765/new/
https://reviews.llvm.org/D121765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:3327-3328
+ /// a pointer to the function or lambda decl for the function or lambda being
+ /// parsed if \p AllowLambda is true. If we're currently in a 'block',
yaxunl updated this revision to Diff 416974.
yaxunl added a comment.
fix comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121765/new/
https://reviews.llvm.org/D121765
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Sema/Sema.cpp
clang/lib/Sema/SemaCUDA.cpp
clang/lib/Sema
tra added a subscriber: rsmith.
tra added a comment.
@rsmith - this touches generic Sema functionality and could use your input.
Overall, the patch looks OK to me.
Comment at: clang/include/clang/Sema/Sema.h:3327-3328
+ /// a pointer to the function or lambda decl for the fun
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added subscribers: carlosgalvezp, guansong.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
CUDA/HIP determines whether a function can