This revision was automatically updated to reflect the committed changes.
Closed by commit rGc261f78d05de: [clang-format] Refactor determineStarAmpUsage
NFC (authored by sstwcw).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121754/new/
https://revi
sstwcw added a comment.
Maybe it's because I removed the final empty line when I pasted the diff as I
thought that LF was a line terminator instead of a line separator. I will try
using arc from now on.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.
I cannot view the diff between the last two revisions:
> Unhandled Exception ("Exception")
> Found unknown intradiff source line, expected a line beginning with "+", "-",
> or " " (space): \ No newline at end of file
sstwcw updated this revision to Diff 419007.
sstwcw retitled this revision from "[clang-format] Refactor
determineStarAmpUsage" to "[clang-format] Refactor determineStarAmpUsage NFC".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121754/new/
https:/
HazardyKnusperkeks added a comment.
Just a side note, I often get this on your changes:
Unhandled Exception ("Exception")
Found unknown intradiff source line, expected a line beginning with "+", "-",
or " " (space): \ No newline at end of file
.
Comment at: clang/unittests/For
sstwcw marked 5 inline comments as done.
sstwcw added inline comments.
Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:85
+ auto Tokens = annotate("x - 0");
+ EXPECT_EQ(Tokens.size(), 4u) << Tokens;
+ EXPECT_TOKEN(Tokens[1], tok::minus, TT_BinaryOperator);
--
sstwcw updated this revision to Diff 417115.
sstwcw marked an inline comment as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121754/new/
https://reviews.llvm.org/D121754
Files:
clang/lib/Format/TokenAnnotator.cpp
clang/unittests/Format/Fo
MyDeveloperDay added a comment.
> But we can: https://gcc.godbolt.org/z/8Mb1xo7oP
This is what I love about you all, you push me to learn more about C++, its a
slippery br
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121754/new/
https://rev
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2146-2147
+// know how they can be followed by a star or amp.
+// co_await, delete - It doesn't make sense to have them followed by a
unary
+// `+` or `-`.
+if (PrevToke
sstwcw marked 5 inline comments as done.
sstwcw added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2146-2147
+// know how they can be followed by a star or amp.
+// co_await, delete - It doesn't make sense to have them followed by a
unary
+//
sstwcw updated this revision to Diff 416450.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121754/new/
https://reviews.llvm.org/D121754
Files:
clang/lib/Format/TokenAnnotator.cpp
clang/unittests/Format/FormatTest.cpp
clang/unittests/Format/Tok
MyDeveloperDay requested changes to this revision.
MyDeveloperDay added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2146-2147
+// know how they can be followed by a star or amp.
+// co_await, delete - I
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2138
+
+// These keywords are deliberately not included here. They are either
+// included in determineStarAmpUsage or determinePlusMinusCaretUsage.
I'm not sure abo
sstwcw marked 3 inline comments as done.
sstwcw added a comment.
About the tokens that were only in one function.
question, colon, and TT_ConditionalExpr, are for same thing. question was
added before they added TT_ConditionalExpr. It looks like now only
TT_ConditionalExpr would be enough.
k
sstwcw updated this revision to Diff 416010.
sstwcw edited the summary of this revision.
sstwcw added a comment.
Add some test cases and use a separate function for the common parts.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121754/new/
https:/
HazardyKnusperkeks requested changes to this revision.
HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2161
-if (PrevToken->isOneOf(tok::l_paren, tok::l_square, tok::l_brace,
- tok::comma, tok::semi, tok::k
curdeius requested changes to this revision.
curdeius added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2161
-if (PrevToken->isOneOf(tok::l_paren, tok::l_square, tok::l_brace,
- to
sstwcw created this revision.
sstwcw added a reviewer: clang-format.
sstwcw added a project: clang-format.
Herald added a project: All.
sstwcw requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
There was some duplicate code in determineStarAmp
18 matches
Mail list logo
