[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-18 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. I’m not blocking it just using the observation to highlight that the rst generated isn’t conformant with best practices. The solution being that a volunteer offers to fix the dump_format_style.py or enduring Format.h isn’t making those mistakes Repository: rG

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-17 Thread Krystian Kuzniarek via Phabricator via cfe-commits
kuzkry added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``AlignC

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-17 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a subscriber: Eugene.Zelenko. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned alon

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``Align

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-17 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``Alig

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-17 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``Alig

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-17 Thread sstwcw via Phabricator via cfe-commits
sstwcw added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for ``AlignC

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-17 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned along with ``=``. + * ``bool AlignCompound`` Only for

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-17 Thread Marek Kurdej via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45cb2df6788c: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst (authored by kuzkry, committed by curdeius). Repository: rG LLVM Github

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-17 Thread Krystian Kuzniarek via Phabricator via cfe-commits
kuzkry added a subscriber: MyDeveloperDay. kuzkry added a comment. I removed @MyDeveloperDay, as this is a trivial PR and already got 3 approvals. Anyway, could someone please deliver this one for me? My name and email in git format is "Krystian Kuzniarek " Repository: rG LLVM Github Monorep

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-15 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. Yes. I probably forgot to generate the doc. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121749/new/ https://reviews.llvm.org/D121749 ___ cfe-commits mailing list cf

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-15 Thread Krystian Kuzniarek via Phabricator via cfe-commits
kuzkry added a comment. @sstwcw, I think you must have forgotten to regenerate the rst file :) I added you as a reviewer to this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121749/new/ https://reviews.llvm.org/D121749

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

2022-03-15 Thread Krystian Kuzniarek via Phabricator via cfe-commits
kuzkry created this revision. kuzkry added reviewers: sstwcw, MyDeveloperDay. kuzkry added a project: clang-format. Herald added a project: All. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Misalignment of clang/docs/ClangFormatSt