[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

This revision was automatically updated to reflect the committed changes. Closed by commit rGa603f566dbe0: [clang] CWG 2354: prohibit alignas for enums (authored by Endill, committed by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121723

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill added a comment. In D121723#3384982 , @ChuanqiXu wrote: > In D121723#3384962 , @Endill wrote: > >> Can somebody commit this? I don't have commit access. > > Hi, what's your prefered name and email addressed

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

ChuanqiXu added a comment. In D121723#3384962 , @Endill wrote: > Can somebody commit this? I don't have commit access. Hi, what's your prefered name and email addressed? I would love to commit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill added a comment. Can somebody commit this? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121723/new/ https://reviews.llvm.org/D121723 ___ cfe-commits mailing list cfe-c

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4291 // declared with the register storage class specifier. An // alignment-specifier may also be applied to the declaration of a class // or enumeration type. erichkea

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill updated this revision to Diff 415529. Endill added a comment. Add a quote from CWG 2354 after a quote from C++11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121723/new/ https://reviews.llvm.org/D121723 Files: clang/include/clang/Basic/D

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a tiny testing nit. It's interesting that WG14 doesn't seem to have a similar DR reported them that I can find (nothing for you to do about it). Comment at: clang/test/CXX/drs/dr2354.cpp:1 +/

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill updated this revision to Diff 415524. Endill added a comment. Fix warning about clang-format being missing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121723/new/ https://reviews.llvm.org/D121723 Files: clang/include/clang/Basic/Diagnos

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Please just note in the comment for the C++11 bit that it is modified by CWG2354, otherwise I think this is good. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4291

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121723 Files: clan