[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6009d0d5801d: [clangd] Track time spent in filesystem ops during preamble builds (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz updated this revision to Diff 417006. adamcz marked an inline comment as done. adamcz added a comment. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121712/new/ https://reviews.llvm.org/D121712 Files: clang-tools-extra/clangd

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! sorry for the long round trip. Comment at: clang-tools-extra/clangd/Preamble.cpp:315 +/// Accumulating wall time timer. Similar to llvm::Timer, but much c

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz added inline comments. Comment at: clang-tools-extra/clangd/FS.h:91 +IntrusiveRefCntPtr +getTimeTrackingFS(std::shared_ptr Timer, + IntrusiveRefCntPtr FS); kadircet wrote: > adamcz wrote: > > kadircet wrote: > > > kadircet wrote: > > > > i

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz updated this revision to Diff 416964. adamcz marked 3 inline comments as done. adamcz added a comment. more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121712/new/ https://reviews.llvm.org/D121712 Files: clang-tools-extr

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FS.h:71 +/// Used for tracking time spent in FS operations. Like llvm::Timer, but only +/// tracks wall time, which is much cheaper. adamcz wrote: > kadircet wrote: > > kadircet wrote: > > > I

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz added a comment. In D121712#3383944 , @Trass3r wrote: > Hmm just a few curious questions from the sidelines. > Why a "custom system" instead of something -ftime-trace based? I'm not sure if I understand. -ftime-trace is a one-off. I want to monito

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz updated this revision to Diff 415919. adamcz marked 12 inline comments as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121712/new/ https://reviews.llvm.org/D121712 Files: clang-tool

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

kadircet added a comment. Thanks, LG in general. I suppose the extra timing overhead should be negligible, considering the preamble build times but would be nice to see some numbers if you have any. Apart from that I've raised the concern around multiple preamble builds finishing in parallel an

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

Trass3r added a comment. Hmm just a few curious questions from the sidelines. Why a "custom system" instead of something -ftime-trace based? How much overhead does this introduce, esp. for normal use-cases? What's the gain? The information is very coarse and general-purpose system profiling tools

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, javed.absar. Herald added a project: All. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extr