shafik added a comment.
@cor3ntin I wonder if these asserts are due to the partial implementation here:
https://github.com/llvm/llvm-project/issues/57960
I am happy to look into it if you can point me in the right direction.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ht
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3784e8ccfbda: [Clang] Fix Unevaluated Lambdas (authored by
cor3ntin).
Changed prior to commit:
https://reviews.llvm.org/D121532?vs=418269&id=41827
aaron.ballman accepted this revision as: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121532/new/
https://reviews.llvm.org/D121532
__
cor3ntin updated this revision to Diff 418269.
cor3ntin added a comment.
- Fix a typo (sorry Aaron, I completely missed that)
- Add a release note
- Clarify why the implementation status is still partial.
This is a bit of a drive-by change but I agree it's a good thing
to clarify.
Repository:
erichkeane added a comment.
Don't forget about Release notes!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121532/new/
https://reviews.llvm.org/D121532
___
cfe-commits mailing list
cfe-commits@lists.llv
aaron.ballman added a comment.
I think this is a sufficient stopgap measure to keep clang from crashing, and I
appreciate the FIXME comment. Should the cxx_status page also be updated, or is
P0315R4 still partial (and if it is, can we add information to the status page
about what's partial if y