[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 417762. cor3ntin added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121532/new/ https://reviews.llvm.org/D121532 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Sema/S

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 417761. cor3ntin added a comment. - Added a couple of tests in ASTImporterTest.cpp - Rename elements of LambdaDependencyKind - Fix ActOnStartOfLambdaDefinition to not use a boolean for LambdaDependencyKind. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

aaron.ballman added a reviewer: clang-language-wg. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:978-979 CXXRecordDecl *Class = createLambdaClosureType(Intro.Range, MethodTyInfo, KnownDependen

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin added a comment. In D121532#3380580 , @shafik wrote: > Can you add a test to `ASTImpoterTest.cpp` that checks that we import the > `LambdaDependencyKind` correctly? Sure, if we agree that the direction is sufficiently palatable (I'm not convin

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

shafik added a comment. Can you add a test to `ASTImpoterTest.cpp` that checks that we import the `LambdaDependencyKind` correctly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121532/new/ https://reviews.llvm.org/D121532 ___

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 415187. cor3ntin added a comment. Remove prior attempt at fixing this bug (good catch Aaron!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121532/new/ https://reviews.llvm.org/D121532 Files: clang/include/

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:12948 + + if (OldClass->isDependentContext()) +getDerived().transformedLocalDecl(OldClass, {Class}); aaron.ballman wrote: > Can you explain why you only do these transformations when

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Adding Erich to look at this WIP for early feedback as he's recently been looking at template instantiation guts rather deeply, but I added some questions. Comment at: clang/include/clang/AST/DeclCXX.h

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Unlike other types, when lambdas are instanciated, th