jdoerfert added a comment.
We want one copy of this, yes. s/omp/llvm_gpu/, sure, though gpu might also not
the best name. Generators, macros, etc. I'm not sold. Even if we want to do
this, let's not conflate that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
JonChesterfield added a comment.
We've got quite a lot of debt in this area and seem at risk of taking on more.
Ideally the cuda and hip and openmp headers would be closer to a single header
containing:
double acosh(double);
INSTANTIATE(acosh, cuda_acosh, amdgpu_acosh, intel_acosh);
tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.
LGTM. Support the header file is actually generated automatically. :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121466/new/
jhuber6 created this revision.
jhuber6 added reviewers: JonChesterfield, tianshilei1992, jdoerfert,
ggeorgakoudis.
Herald added subscribers: asavonic, dang, guansong, yaxunl, mgorny.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, sste
