This revision was automatically updated to reflect the committed changes.
Closed by commit rG5791e28f3016: Complete the list of single-underscore
keywords for MSVC compat. (authored by efriedma).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121412/n
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121412/new/
https://reviews.llvm.org/D121412
___
cfe-c
efriedma updated this revision to Diff 415136.
efriedma added a comment.
Use KEYMSCOMPAT
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121412/new/
https://reviews.llvm.org/D121412
Files:
clang/include/clang/Basic/TokenKinds.def
Index: clang/in
efriedma added a comment.
That makes sense, sure. -fms-compatibility is on by default for clang-cl
anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121412/new/
https://reviews.llvm.org/D121412
___
rnk added a subscriber: rsmith.
rnk added a comment.
@rsmith has previously advocated for a policy of only permitting conforming
language extensions under fms-extensions. These single underscore names are not
in the implementors namespace, so he has argued they should be under
fms-compatibility
efriedma updated this revision to Diff 414499.
efriedma added a comment.
Drop _except; __except is a contextual keyword.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121412/new/
https://reviews.llvm.org/D121412
Files:
clang/include/clang/Basic/
efriedma created this revision.
efriedma added reviewers: rnk, mstorsjo.
Herald added a subscriber: dexonsmith.
Herald added a project: All.
efriedma requested review of this revision.
Herald added a project: clang.
List derived from https://docs.microsoft.com/en-us/cpp/cpp/keywords-cpp . Not
th
