This revision was automatically updated to reflect the committed changes.
Closed by commit rGa7c08bcf777e: [flang][driver] Add support for `-mllvm`
(authored by awarzynski).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121374/new/
https://reviews.l
awarzynski updated this revision to Diff 414648.
awarzynski added a comment.
Fix option spelling in test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121374/new/
https://reviews.llvm.org/D121374
Files:
clang/include/clang/Driver/Options.td
cl
awarzynski added inline comments.
Comment at: flang/test/Driver/mllvm.f90:1
+! Test the `-mlvm` option
+
xbolva00 wrote:
> awarzynski wrote:
> > xbolva00 wrote:
> > > mllvm
> > Does it matter? `-mllvm` is consistent with other tests in this directory
> > (e.g.
xbolva00 added inline comments.
Comment at: flang/test/Driver/mllvm.f90:1
+! Test the `-mlvm` option
+
awarzynski wrote:
> xbolva00 wrote:
> > mllvm
> Does it matter? `-mllvm` is consistent with other tests in this directory
> (e.g.
> https://github.com/llvm/ll
awarzynski added inline comments.
Comment at: flang/test/Driver/mllvm.f90:1
+! Test the `-mlvm` option
+
xbolva00 wrote:
> mllvm
Does it matter? `-mllvm` is consistent with other tests in this directory (e.g.
https://github.com/llvm/llvm-project/blob/main/flang/
shraiysh added a comment.
LGTM (will let others review as this includes changes to clang too and I am not
familiar with it)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121374/new/
https://reviews.llvm.org/D121374
___
xbolva00 added inline comments.
Comment at: flang/test/Driver/mllvm.f90:1
+! Test the `-mlvm` option
+
mllvm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121374/new/
https://reviews.llvm.org/D121374
awarzynski created this revision.
awarzynski added reviewers: rovka, schweitz, Leporacanthicus,
kiranchandramohan, shraiysh.
Herald added a reviewer: sscalpone.
Herald added a subscriber: dang.
Herald added projects: Flang, All.
awarzynski requested review of this revision.
Herald added subscriber