This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0a27622a1d62: [NVPTX] Disable DWARF .file directory for PTX
(autho
probinson added a comment.
I'm okay with doing it this way. My impression over the years (as a debug-info
guy, not as a ptxas user) is that ptxas evolves slowly and this is not really
"busy work."
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121
asavonic added a comment.
I'm going to merge the patch in a couple of days, unless anyone has a strong
opinion against it.
Alternative options:
- revert this default back to false (not great for other targets)
- add a check for `Triple == NVPTX` directly to llc (tools other than llc will
have t
asavonic added a comment.
Herald added a subscriber: mattd.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121299/new/
https://reviews.llvm.org/D121299
___
cfe-commits mailing list
cfe-commits@lists.
asavonic added a comment.
Herald added a subscriber: gchakrabarti.
@MaskRay, should we merge this patch or rework it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121299/new/
https://reviews.llvm.org/D121299
__
asavonic updated this revision to Diff 418011.
asavonic added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
- Fixed Clang build.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121299/new/
https://reviews.llvm.org/
