This revision was automatically updated to reflect the committed changes.
Closed by commit rG77924d60efa8: [clang][deps] Modules don't contribute to
search path usage (authored by jansvoboda11).
Changed prior to commit:
https://reviews.llvm.org/D121295?vs=415381&id=415776#toc
Repository:
rG
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
Nice! LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121295/new/
https://reviews.llvm.org/D121295
jansvoboda11 updated this revision to Diff 415381.
jansvoboda11 added a comment.
Undo unrelated changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121295/new/
https://reviews.llvm.org/D121295
Files:
clang/lib/Lex/HeaderSearch.cpp
clang/test
dexonsmith added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:305
// maps, searching for a module map that describes this module.
- for (It = search_dir_begin(); It != search_dir_end(); ++It) {
-if (It->isFramework()) {
+ for (DirectoryLookup Dir : search_
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
To reduce the number of modules we build in explicit builds (