silvas added inline comments.
Comment at: docs/BuildingLibcxx.rst:57
@@ +56,3 @@
+ select a safe place to install libc++.
+
+ * ``make install-libcxx install-libcxxabi`` --- Will install the libraries
and the headers
silvas wrote:
> jroelofs wrote:
> > I feel l
silvas added inline comments.
Comment at: docs/BuildingLibcxx.rst:57
@@ +56,3 @@
+ select a safe place to install libc++.
+
+ * ``make install-libcxx install-libcxxabi`` --- Will install the libraries
and the headers
jroelofs wrote:
> I feel like a warning is n
jroelofs added inline comments.
Comment at: docs/BuildingLibcxx.rst:57
@@ +56,3 @@
+ select a safe place to install libc++.
+
+ * ``make install-libcxx install-libcxxabi`` --- Will install the libraries
and the headers
I feel like a warning is not enough... per
EricWF added inline comments.
Comment at: docs/BuildingLibcxx.rst:56
@@ +55,3 @@
+Mac users, remember to be careful when replacing the system's libc++.
+**Your system will not be able to boot without a functioning libc++.**
+
jroelofs wrote:
> Is there a way to ma
EricWF updated this revision to Diff 32718.
EricWF marked an inline comment as done.
EricWF updated the summary for this revision.
EricWF added a comment.
Address review comments.
http://reviews.llvm.org/D12129
Files:
CMakeLists.txt
cmake/Modules/HandleOutOfTreeLLVM.cmake
cmake/config-ix.
danalbert accepted this revision.
danalbert added a comment.
I think I prefer the haiku style, but I couldn't give you any concrete reasons
for that.
http://reviews.llvm.org/D12129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
Both styles look ok to me, with a slight preference toward matching clang's.
Comment at: docs/BuildingLibcxx.rst:56
@@ +55,3 @@
+Mac users, remember to be careful when rep
EricWF added a comment.
Gentle ping. There is going to be a couple of days lag time between committing
this and it showing up at libcxx.llvm.org/docs.
Once it is available at `libcxx.llvm.org/docs` we still have time to review it
before we link to it from the homepage.
For this reason, and beca
EricWF added a comment.
I've uploaded a version of the docs built with the "haiku" theme to
http://efcs.ca/libcxx-haiku-docs. I would like other's input on which style
they prefer (Note: The LLVM themed docs are here http://efcs.ca/libcxx-docs).
http://reviews.llvm.org/D12129
__
EricWF added a comment.
In http://reviews.llvm.org/D12129#227320, @silvas wrote:
> From a Sphinx perspective, this looks fine to me. You may want to consider
> using `html_theme = 'haiku'` for consistency with clang, but reusing LLVM's
> is fine. (the reason I had clang use 'haiku' is that it i
silvas added a subscriber: silvas.
silvas added a comment.
From a Sphinx perspective, this looks fine to me. You may want to consider
using `html_theme = 'haiku'` for consistency with clang, but reusing LLVM's is
fine. (the reason I had clang use 'haiku' is that it is a bit better put
together
EricWF created this revision.
EricWF added reviewers: jroelofs, chandlerc, danalbert, mclow.lists.
EricWF added a subscriber: cfe-commits.
This patch adds Sphinx based documentation to libc++. The goal is to make it
easier to write documentation for libc++ since writing new documentation in
HTML
12 matches
Mail list logo
