[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. In D121283#3392137 , @thakis wrote: > The commit message got a bit mutilated: > 33a9eac6aaa495fce6fd9b17cd48aa57a95461e6 > > > Just FYI in case you didn't n

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

thakis added a comment. The commit message got a bit mutilated: 33a9eac6aaa495fce6fd9b17cd48aa57a95461e6 Just FYI in case you didn't notice. In that case, update your commit workflow to make sure this doesn't happen next tim

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33a9eac6aaa4: [Clang] Support multiple attributes in a single pragma (authored by egorzhdan). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan updated this revision to Diff 416279. egorzhdan added a comment. - Fix off-by-one error in fix-it generation logic: the last SubjectMatchRule (`SubjectMatchRule_variable_not_is_parameter`) was not handled properly - Add a test for this Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. Thanks for the review @aaron.ballman! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121283/new/ https://reviews.llvm.org/D121283 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan updated this revision to Diff 415527. egorzhdan added a comment. Merge two test files into one to speed up testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121283/new/ https://reviews.llvm.org/D121283 Files: clang/docs/LanguageExt

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor testing nit, this LGTM. Thank you for the new functionality! Comment at: clang/test/Parser/pragma-multiple-attributes.cpp:1-11 +// RUN: %clan

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan updated this revision to Diff 415199. egorzhdan added a comment. - Only allow one attribute syntax style per directive - Adjust documentation - Add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121283/new/ https://reviews.l

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. In D121283#3379225 , @aaron.ballman wrote: > As a thought experiment, would it make sense to lift the restriction on the > number of attributes allowed in a pragma, but not allow multiple attribute > specifiers? I think this

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

aaron.ballman added a comment. In D121283#3375806 , @egorzhdan wrote: > In D121283#3373560 , @aaron.ballman > wrote: > >> why do we support multiple attribute *specifiers* in the same pragma? I >> would not expe

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. In D121283#3373560 , @aaron.ballman wrote: > why do we support multiple attribute *specifiers* in the same pragma? I would > not expect to be able to mix attribute styles in the same pragma given that > all of the individual

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

aaron.ballman added a comment. Thanks for this, I plan on giving it a more thorough review when I can. But the summary led me to a design question: why do we support multiple attribute *specifiers* in the same pragma? I would not expect to be able to mix attribute styles in the same pragma give

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan updated this revision to Diff 414068. egorzhdan added a comment. Remove unused include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121283/new/ https://reviews.llvm.org/D121283 Files: clang/include/clang/Basic/AttrSubjectMatchRules.h

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan created this revision. egorzhdan added a reviewer: arphaman. Herald added a subscriber: jdoerfert. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds support for multiple attributes in