Prazek accepted this revision.
Prazek added a reviewer: Prazek.
Prazek added a comment.
This revision is now accepted and ready to land.
Have to accept revision to close it
http://reviews.llvm.org/D12128
___
cfe-commits mailing list
cfe-commits@list
Prazek updated this revision to Diff 32587.
http://reviews.llvm.org/D12128
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-available-externally.cpp
Index: test/CodeGenCXX/vtable-available-externally.cpp
=
rjmccall added a comment.
LGTM.
http://reviews.llvm.org/D12128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek updated this revision to Diff 32509.
Prazek added a comment.
Added tests, and changed the VTableComponent code which was wrong on so many
levels. Sorry
http://reviews.llvm.org/D12128
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-avai
rsmith added a comment.
This looks fine; can you add a testcase?
http://reviews.llvm.org/D12128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek created this revision.
Prazek added reviewers: rsmith, majnemer, rjmccall.
Prazek added a subscriber: cfe-commits.
Bugfix revealed in r245264.
http://reviews.llvm.org/D12128
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/ItaniumCXXABI.cpp
Index: lib/CodeGen/ItaniumCXXABI.cpp
==
